| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode |
| Date: | 2023-04-26 11:26:43 |
| Message-ID: | CAApHDvrk_ozPh37B_oVoVK8ODztxhrvXikzprpe+HU8rqddvwA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 26 Apr 2023, 8:48 pm Masahiko Sawada, <sawada(dot)mshk(at)gmail(dot)com> wrote:
> I realized that the value of vacuum_buffer_usage_limit parameter in
> postgresql.conf.sample doesn't have the unit:
>
> #vacuum_buffer_usage_limit = 256 # size of vacuum and analyze buffer
> access strategy ring.
> # 0 to disable vacuum buffer access
> strategy
> # range 128kB to 16GB
>
> It works but I think we might want to add the unit kB for
> understandability and consistency with other GUC_UNIT_KB parameters.
> I've attached a small patch that adds the unit and aligns the indent
> of the comments to the perimeter parameters.
>
I'm not currently able to check, but if work_mem has a unit in the sample
conf then I agree that vacuum_buffer_usage_limit should too.
I'm fine for you to go ahead and adjust this, otherwise it'll be Monday
before I can.
David
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2023-04-26 11:31:36 | RE: Support logical replication of DDLs |
| Previous Message | Amit Kapila | 2023-04-26 11:21:11 | Re: Perform streaming logical transactions by background workers and parallel apply |