Re: HEAPDEBUGALL is broken

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: HEAPDEBUGALL is broken
Date: 2020-04-19 13:37:08
Message-ID: 26609.1587303428@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> The HEAPDEBUGALL define has been broken since PG12 due to tableam
> changes. Should we just remove this? It doesn't look very useful.
> It's been around since Postgres95.
> If we opt for removing: PG12 added an analogous HEAPAMSLOTDEBUGALL
> (which still compiles correctly). Would we want to keep that?

+1 for removing both. There are a lot of such debug "features"
in the code, and few of them are worth anything IME.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message James Coleman 2020-04-19 13:46:55 Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Previous Message Tom Lane 2020-04-19 13:23:01 Re: Poll: are people okay with function/operator table redesign?