| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: HEAPDEBUGALL is broken |
| Date: | 2020-04-21 18:11:26 |
| Message-ID: | e1309adf-a0f3-c5dd-7654-7034418b043e@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-04-19 15:37, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> The HEAPDEBUGALL define has been broken since PG12 due to tableam
>> changes. Should we just remove this? It doesn't look very useful.
>> It's been around since Postgres95.
>> If we opt for removing: PG12 added an analogous HEAPAMSLOTDEBUGALL
>> (which still compiles correctly). Would we want to keep that?
>
> +1 for removing both. There are a lot of such debug "features"
> in the code, and few of them are worth anything IME.
removed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-04-21 18:27:44 | Re: HEAPDEBUGALL is broken |
| Previous Message | Peter Eisentraut | 2020-04-21 18:01:53 | Re: HEAPDEBUGALL is broken |