| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: HEAPDEBUGALL is broken |
| Date: | 2020-04-23 03:44:18 |
| Message-ID: | 20200423034418.coxgdnfmnkiflkde@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-04-19 09:37:08 -0400, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> > The HEAPDEBUGALL define has been broken since PG12 due to tableam
> > changes. Should we just remove this? It doesn't look very useful.
> > It's been around since Postgres95.
> > If we opt for removing: PG12 added an analogous HEAPAMSLOTDEBUGALL
> > (which still compiles correctly). Would we want to keep that?
>
> +1 for removing both. There are a lot of such debug "features"
> in the code, and few of them are worth anything IME.
Belatedly: +many
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2020-04-23 04:05:45 | Re: xid wraparound danger due to INDEX_CLEANUP false |
| Previous Message | Andres Freund | 2020-04-23 03:32:56 | Re: xid wraparound danger due to INDEX_CLEANUP false |