Re: SPI-header-files safe for C++-compiler

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Jacob Rief" <jacob(dot)rief(at)gmx(dot)at>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: SPI-header-files safe for C++-compiler
Date: 2007-07-02 20:57:22
Message-ID: 22646.1183409842@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Jacob Rief" <jacob(dot)rief(at)gmx(dot)at> writes:
>> Tom Lane writes:
>> Anyway, at this point my concern is not so much whether we could fix
>> it as what is the plan for keeping it fixed.

> A best practice statement, telling developers not use C++-keywords as identifiers in header-files.

That will have exactly zero effect. As was shown upthread, even
everyday C++ programmers don't remember what all the extra keywords are.
Guys who mainly code C are very unlikely to get this right if there's no
automatic check being applied.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Jim C. Nasby 2007-07-02 21:52:22 Still recommending daily vacuum...
Previous Message Jacob Rief 2007-07-02 20:33:25 Re: SPI-header-files safe for C++-compiler