Re: pgsql: Fix for early log messages during postmaster startup getting lost

Neil Conway <neilc(at)samurai(dot)com> writes:
> FYI, it is considered good practise to commit a patch at approximately
> (or exactly) the same time on all branches, so tools like cvs2cl will be
> more likely to collect the changes together.

It's also helpful to use exactly the same text for the log messages in
all the branches. Again, this is so that cvs2cl understands they're
the same patch. I tend not to bother with "Backpatch to xxx" comments,
as the CVS log makes that perfectly clear anyway; but if you use them,
they should be the same for all branches committed to.

> Comments like that are fragile (elog.c could change, for example), and
> basically content-free anyway, IMHO. If you need to make SysLoggerPID
> part of postmaster.c's external API, why not just do that, remove the
> comment, and add the extern declaration to postmaster.h?

The counterargument is that he avoided exporting SysLoggerPID to
anything except elog.c. If it's in postmaster.h then who knows what
will start depending on it? But I see Neil's point too; this coding
is definitely a bit fragile.

regards, tom lane