| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Fix for early log messages during postmaster startup getting lost |
| Date: | 2007-02-12 03:45:47 |
| Message-ID: | 1171251947.5454.200.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sun, 2007-02-11 at 07:59 -0400, Magnus Hagander wrote:
> Fix for early log messages during postmaster startup getting lost when
> running as a service on Win32.
FYI, it is considered good practise to commit a patch at approximately
(or exactly) the same time on all branches, so tools like cvs2cl will be
more likely to collect the changes together.
> pgsql/src/backend/postmaster:
> postmaster.c (r1.519 -> r1.520)
> (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/postmaster.c.diff?r1=1.519&r2=1.520)
Comments like that are fragile (elog.c could change, for example), and
basically content-free anyway, IMHO. If you need to make SysLoggerPID
part of postmaster.c's external API, why not just do that, remove the
comment, and add the extern declaration to postmaster.h?
-Neil
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-02-12 04:47:01 | Re: pgsql: Fix for early log messages during postmaster startup getting lost |
| Previous Message | Peter Eisentraut | 2007-02-11 22:18:16 | pgsql: Add support for optionally escaping periods when converting SQL |