From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Neil Conway <neilc(at)samurai(dot)com>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Fix for early log messages during postmaster startup getting lost |
Date: | 2007-02-12 08:32:20 |
Message-ID: | 20070212083220.GA4432@svr2.hagander.net |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Sun, Feb 11, 2007 at 11:47:01PM -0500, Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
> > FYI, it is considered good practise to commit a patch at approximately
> > (or exactly) the same time on all branches, so tools like cvs2cl will be
> > more likely to collect the changes together.
Ok. I specifically delayed the second parts to see it run on a couple of
different platforms on th ebuildfarm. Wasn't aware of that part of how
cvs2cl worked - will do different next time.
> It's also helpful to use exactly the same text for the log messages in
> all the branches. Again, this is so that cvs2cl understands they're
> the same patch. I tend not to bother with "Backpatch to xxx" comments,
> as the CVS log makes that perfectly clear anyway; but if you use them,
> they should be the same for all branches committed to.
Ok. Wasn't aware of that part either, but will try to remember next time.
> > Comments like that are fragile (elog.c could change, for example), and
> > basically content-free anyway, IMHO. If you need to make SysLoggerPID
> > part of postmaster.c's external API, why not just do that, remove the
> > comment, and add the extern declaration to postmaster.h?
>
> The counterargument is that he avoided exporting SysLoggerPID to
> anything except elog.c. If it's in postmaster.h then who knows what
> will start depending on it? But I see Neil's point too; this coding
> is definitely a bit fragile.
That was my argument for doing it the way I did. I'll change it if you
want me to, of course :-) I can see both arguments, but can't quite
decide which wins...
//Magnus
From | Date | Subject | |
---|---|---|---|
Next Message | User Okbob | 2007-02-12 10:02:51 | plpsm - plpgpsm: rollback removing ifndef for pre phantom version and |
Previous Message | Tom Lane | 2007-02-12 04:47:01 | Re: pgsql: Fix for early log messages during postmaster startup getting lost |