From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Neil Conway <neilc(at)samurai(dot)com>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Fix for early log messages during postmaster startup getting lost |
Date: | 2007-02-12 22:37:12 |
Message-ID: | 200702122237.l1CMbCr08413@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Magnus Hagander wrote:
> > > Comments like that are fragile (elog.c could change, for example), and
> > > basically content-free anyway, IMHO. If you need to make SysLoggerPID
> > > part of postmaster.c's external API, why not just do that, remove the
> > > comment, and add the extern declaration to postmaster.h?
> >
> > The counterargument is that he avoided exporting SysLoggerPID to
> > anything except elog.c. If it's in postmaster.h then who knows what
> > will start depending on it? But I see Neil's point too; this coding
> > is definitely a bit fragile.
>
> That was my argument for doing it the way I did. I'll change it if you
> want me to, of course :-) I can see both arguments, but can't quite
> decide which wins...
I add it so the commit message on HEAD also shows the back branchs. It
makes it easier when creating the major release notes whether the patch
has already appeared in a back branch, and hence shouldn't be mentioned.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Jeremy Drake | 2007-02-12 23:31:50 | Re: pgsql: Fix backend crash in parsing incorrect tsquery. |
Previous Message | Tom Lane | 2007-02-12 17:19:31 | pgsql: Avoid infinite recursion when dumping new planner |