Re: Add support for AT LOCAL

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Vik Fearing <vik(at)postgresfriends(dot)org>, cary huang <hcary328(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add support for AT LOCAL
Date: 2023-10-16 03:02:45
Message-ID: 2188264.1697425365@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> On Mon, Oct 16, 2023 at 2:58 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> Another theory would be one of these weird compiler optimization issue
>> from xlc? In recent history, there was 8d2a01ae12cd.

> Yeah, there are more like that too. xlc 12.1 is dead (like the OS
> version it shipped with). New versions are available on cfarm if we
> care about this target. But I am conscious of the cosmic law that if
> you blame the compiler too soon you can cause the bug to move into
> your code...

I'm having a hard time not believing that this is a compiler bug.
Looking back at 8d2a01ae12cd and its speculation that xlc is overly
liberal about reordering code around sequence points ... I wonder
if it'd help to do this calculation in a local variable, and only
assign the final value to result->time ? But we have to reproduce
the problem first.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Wienhold 2023-10-16 03:03:18 Re: Patch: Improve Boolean Predicate JSON Path Docs
Previous Message Thomas Munro 2023-10-16 02:53:56 Re: Add support for AT LOCAL