Re: [HACKERS] pg_dump not in very good shape

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] pg_dump not in very good shape
Date: 2000-01-17 16:22:53
Message-ID: 21021.948126173@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <e99re41(at)DoCS(dot)UU(dot)SE> writes:
>>>> A better idea would be to do what psql does with snprintf: Just include
>>>> the [v]snprintf.o file in the compilation (linking) conditionally.
>>
>> Sorry if I was unclear, but that was exactly what I meant.
>>
>> BTW, since this is now done in libpq, you could probably remove
>> snprintf.o from psql ...

> Hmm, maybe this is not what I meant. I meant adding the linking line to
> pg_dump, not libpq.

Not a usable answer: that would mean that *every* application using
libpq would have to start including backend/port/snprintf.o, on the
platforms where vsnprintf doesn't exist.

> But I guess as long as we don't tell anyone about it
> (vsnprintf being in libpq)

It's certainly not going to become a published part of the interface,
if that's what you mean.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2000-01-17 16:29:58 Re: [HACKERS] RE: Getting rid of setheapoverride (was Re: [COMMITTERS] heap.c)
Previous Message Tom Lane 2000-01-17 16:19:59 Re: [HACKERS] RE: Getting rid of setheapoverride (was Re: [COMMITTERS] heap.c)