Re: [HACKERS] pg_dump not in very good shape

From: Peter Eisentraut <e99re41(at)DoCS(dot)UU(dot)SE>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] pg_dump not in very good shape
Date: 2000-01-17 11:07:43
Message-ID: Pine.GSO.4.02A.10001171205210.8593-100000@Puma.DoCS.UU.SE
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 17 Jan 2000, Tom Lane wrote:

> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > On 2000-01-15, Tom Lane mentioned:
> >> I am inclined to go ahead and insert vsnprintf into libpq.
>
> > I think including this in libpq is the wrong way to go. [snip]
> > A better idea would be to do what psql does with snprintf: Just include
> > the [v]snprintf.o file in the compilation (linking) conditionally.
>
> Sorry if I was unclear, but that was exactly what I meant.
>
> BTW, since this is now done in libpq, you could probably remove
> snprintf.o from psql ...

Hmm, maybe this is not what I meant. I meant adding the linking line to
pg_dump, not libpq. But I guess as long as we don't tell anyone about it
(vsnprintf being in libpq) we can safely take it out later if someone has
a better plan.

--
Peter Eisentraut Sernanders vaeg 10:115
peter_e(at)gmx(dot)net 75262 Uppsala
http://yi.org/peter-e/ Sweden

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2000-01-17 11:13:35 Re: [HACKERS] TODO list
Previous Message Patrick Welche 2000-01-17 10:49:59 Re: [HACKERS] flex