Re: Statistics Import and Export

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Statistics Import and Export
Date: 2024-11-27 15:57:35
Message-ID: 202411271557.gaewckwu64dm@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2024-Nov-27, Bruce Momjian wrote:

> On Wed, Nov 27, 2024 at 09:18:45AM -0600, Nathan Bossart wrote:

> > > Maybe not remove the option, but add a required parameter:
> > > --analyze-in-stages=all / missing
> > >
> > > That way, if the option is missing, the user can adapt the command line
> > > according to need.
> >
> > I like this idea.
>
> Would there be a default?

There would be no default. Running with no option given would raise an
error. The point is: you want to break scripts currently running
--analyze-in-stages so that they can make a choice of which of these two
modes to run. Your proposal (as I understand it) is to remove the
--analyze-in-stages option and add two other options. My proposal is to
keep --analyze-in-stages, but require it to have a specifier of which
mode to run. Both achieve what you want, but I think mine achieves it
in a cleaner way.

> Uh, do we have parameters that require a boolean option like this?

I'm not sure what exactly are you asking here.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"La gente vulgar sólo piensa en pasar el tiempo;
el que tiene talento, en aprovecharlo"

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2024-11-27 15:59:18 Re: Large expressions in indexes can't be stored (non-TOASTable)
Previous Message Mark Dilger 2024-11-27 15:51:15 Re: Index AM API cleanup