Re: Doc: typo in config.sgml

From: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Doc: typo in config.sgml
Date: 2024-09-30 09:03:30
Message-ID: 20240930180330.a8095414f7fa4e32d9f16985@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 30 Sep 2024 17:23:24 +0900 (JST)
Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:

> >> I think there's an unnecessary underscore in config.sgml.
> >> Attached patch fixes it.
> >
> > I could not apply the patch with an error.
> >
> > error: patch failed: doc/src/sgml/config.sgml:9380
> > error: doc/src/sgml/config.sgml: patch does not apply
>
> Strange. I have no problem applying the patch here.
>
> > I found your patch contains an odd character (ASCII Code 240?)
> > by performing `od -c` command on the file. See the attached file.
>
> Yes, 240 in octal (== 0xc2) is in the patch but it's because current
> config.sgml includes the character. You can check it by looking at
> line 9383 of config.sgml.

Yes, you are right, I can find the 0xc2 char in config.sgml using od -c,
although I still could not apply the patch.

I think this is non-breaking space of (C2A0) of utf-8. I guess my
terminal normally regards this as a space, so applying patch fails.

I found it also in line 85 of ref/drop_extension.sgml.

>
> I think it was introduced by 28e858c0f95.
>
> Best reagards,
> --
> Tatsuo Ishii
> SRA OSS K.K.
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp

--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2024-09-30 09:03:44 Re: Doc: typo in config.sgml
Previous Message Peter Smith 2024-09-30 08:45:54 Re: Pgoutput not capturing the generated columns