Re: Doc: typo in config.sgml

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: nagata(at)sraoss(dot)co(dot)jp
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Doc: typo in config.sgml
Date: 2024-10-01 03:02:27
Message-ID: 20241001.120227.229328146975369640.ishii@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Mon, 30 Sep 2024 17:23:24 +0900 (JST)
> Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>
>> >> I think there's an unnecessary underscore in config.sgml.
>> >> Attached patch fixes it.
>> >
>> > I could not apply the patch with an error.
>> >
>> > error: patch failed: doc/src/sgml/config.sgml:9380
>> > error: doc/src/sgml/config.sgml: patch does not apply
>>
>> Strange. I have no problem applying the patch here.
>>
>> > I found your patch contains an odd character (ASCII Code 240?)
>> > by performing `od -c` command on the file. See the attached file.
>>
>> Yes, 240 in octal (== 0xc2) is in the patch but it's because current
>> config.sgml includes the character. You can check it by looking at
>> line 9383 of config.sgml.
>
> Yes, you are right, I can find the 0xc2 char in config.sgml using od -c,
> although I still could not apply the patch.
>
> I think this is non-breaking space of (C2A0) of utf-8. I guess my
> terminal normally regards this as a space, so applying patch fails.
>
> I found it also in line 85 of ref/drop_extension.sgml.

Thanks. I have pushed the fix for ref/drop_extension.sgml along with
config.sgml.

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2024-10-01 04:18:09 Re: Conflict Detection and Resolution
Previous Message Yuya Watari 2024-10-01 02:35:05 Re: [PoC] Reducing planning time when tables have many partitions