Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: orlovmg(at)gmail(dot)com
Cc: dgrowleyml(at)gmail(dot)com, ashutosh(dot)bapat(dot)oss(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN
Date: 2024-09-04 00:06:57
Message-ID: 20240904.090657.995734319001610943.ishii@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Hi!
>
> +1 for the idea of the patch. Consider it useful.
>
> I looked at the patch set and don't see any obvious defects. It applies
> without any problems and looks pretty good for me.

Thank you for reviewing my patch.

> Only one thing is left to do. Add basic tests for the added functionality
> to make it committable. For example, as in the
> mentioned 1eff8279d494b9.

Agreed. Probably add to explain.sql?

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-09-04 00:40:01 Re: Test 041_checkpoint_at_promote.pl faild in installcheck due to missing injection_points
Previous Message Ilya Gladyshev 2024-09-03 23:28:23 Re: optimizing pg_upgrade's once-in-each-database steps