| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall |
| Date: | 2024-05-09 19:34:25 |
| Message-ID: | 20240509193425.GA3219615@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 09, 2024 at 09:03:56AM +0900, Michael Paquier wrote:
> +1. Could there be an argument in favor of a backpatch? This is a
> performance improvement, but one could also side that the addition of
> sync support in pg_dump[all] has made that a regression that we'd
> better fix because the flushes don't matter in this context. They
> also bring costs for no gain.
I don't see a strong need to back-patch this, if for no other reason than
it seems to have gone unnoticed for 7 major versions. Plus, based on my
admittedly limited testing, this is unlikely to provide significant
improvements.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2024-05-09 19:36:30 | Re: Is there an undocumented Syntax Check in Meson? |
| Previous Message | Dave Cramer | 2024-05-09 19:33:40 | Re: request for database identifier in the startup packet |