| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Is there an undocumented Syntax Check in Meson? |
| Date: | 2024-05-09 19:36:30 |
| Message-ID: | 20240509193630.zpza5mjd7dkmsgm4@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2024-05-09 20:12:38 +0100, Dagfinn Ilmari Mannsåker wrote:
> Attached is a patch which adds a check-docs target for meson, which
> takes 0.3s on my laptop.
Nice.
> +checkdocs = custom_target('check-docs',
> + input: 'postgres.sgml',
> + output: 'check-docs',
> + depfile: 'postgres-full.xml.d',
> + command: [xmllint, '--nonet', '--valid', '--noout',
> + '--path', '@OUTDIR@', '@INPUT@'],
> + depends: doc_generated,
> + build_by_default: false,
> +)
> +alias_target('check-docs', checkdocs)
Isn't the custom target redundant with postgres_full_xml? I.e. you could just
have the alias_target depend on postgres_full_xml?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari Mannsåker | 2024-05-09 19:38:24 | Re: open items |
| Previous Message | Nathan Bossart | 2024-05-09 19:34:25 | Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall |