From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Reduce branches in heapgetpage()'s per-tuple loop |
Date: | 2024-04-07 17:26:15 |
Message-ID: | 20240407172615.cocrsvboqm3ttqe4@awork3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Hi,
On 2024-04-07 09:14:57 -0400, Melanie Plageman wrote:
> On Sun, Apr 7, 2024 at 3:29 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> >
> > Reduce branches in heapgetpage()'s per-tuple loop
> >
> > Until now, heapgetpage()'s loop over all tuples performed some conditional
> > checks for each tuple, even though condition did not change across the loop.
>
> I haven't reviewed exactly what this does, but heapgetpage() was
> removed (or split into two functions, rather) in 44086b097537, so I
> find the naming of this function, or, at least the comments, commit
> message and description a bit confusing.
Oops. That name was so ingrained in my head that despite looking over these
lines quite a few times, I couldn't spot that.
Will send an update to the thread.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2024-04-07 17:31:31 | pgsql: Improve check in LDAP test to find the OpenLDAP installation |
Previous Message | Melanie Plageman | 2024-04-07 15:28:40 | Re: pgsql: Use bump memory context for tuplesorts |