Re: pgsql: Reduce branches in heapgetpage()'s per-tuple loop

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Reduce branches in heapgetpage()'s per-tuple loop
Date: 2024-04-07 13:14:57
Message-ID: CAAKRu_ZXtWKCE-7XC5pJchUXRe9kQZmgX-NQjnc3BnO=nHRhrA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, Apr 7, 2024 at 3:29 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Reduce branches in heapgetpage()'s per-tuple loop
>
> Until now, heapgetpage()'s loop over all tuples performed some conditional
> checks for each tuple, even though condition did not change across the loop.

I haven't reviewed exactly what this does, but heapgetpage() was
removed (or split into two functions, rather) in 44086b097537, so I
find the naming of this function, or, at least the comments, commit
message and description a bit confusing.

- Melanie

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2024-04-07 13:56:21 pgsql: Use streaming I/O in sequential scans.
Previous Message David Rowley 2024-04-07 12:32:48 pgsql: Use bump memory context for tuplesorts