| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <drowley(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Use bump memory context for tuplesorts |
| Date: | 2024-04-07 15:28:40 |
| Message-ID: | CAAKRu_Y6dZjiJEZghgNZp0Gjar1JVq-CH7XGDqExDVHnPgDjuw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sun, Apr 7, 2024 at 8:32 AM David Rowley <drowley(at)postgresql(dot)org> wrote:
>
> Use bump memory context for tuplesorts
>
> 29f6a959c added a bump allocator type for efficient compact allocations.
> Here we make use of this for non-bounded tuplesorts to store tuples.
> This is very space efficient when storing narrow tuples due to bump.c
> not having chunk headers. This means we can fit more tuples in work_mem
> before spilling to disk, or perform an in-memory sort touching fewer
> cacheline.
Looks like this assert is tripping on grison [1].
running bootstrap script ... TRAP: failed Assert("total_allocated ==
context->mem_allocated"), File: "bump.c", Line: 808, PID: 30248
[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=grison&dt=2024-04-07%2014%3A10%3A09
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2024-04-07 17:26:15 | Re: pgsql: Reduce branches in heapgetpage()'s per-tuple loop |
| Previous Message | Thomas Munro | 2024-04-07 13:56:21 | pgsql: Use streaming I/O in sequential scans. |