| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Xing Guo <higuoxing(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [plpython] Add missing volatile qualifier. |
| Date: | 2024-04-01 18:29:20 |
| Message-ID: | 20240401182920.GA2299671@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 01, 2024 at 11:57:07AM -0400, Tom Lane wrote:
> Xing Guo <higuoxing(at)gmail(dot)com> writes:
>> I'm playing a toy static analysis checker with PostgreSQL and found a
>> variable is missing volatile qualifier.
>
> Good catch! It looks like the consequences of a failure would be
> pretty minimal --- AFAICS, no worse than a possible failure to remove
> a refcount on Py_None --- but that's still a bug.
Huh. I seem to have dropped that "volatile" shortly before committing for
some reason [0].
> I don't care for your proposed fix though. I think the real problem
> here is schizophrenia about when to set up pltargs, and we could
> fix it more nicely as attached. (Perhaps the Asserts are overkill
> though.)
Your fix seems fine to me.
[0] https://postgr.es/m/20230504234235.GA2419591%40nathanxps13
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-04-01 18:39:05 | Re: [plpython] Add missing volatile qualifier. |
| Previous Message | Tom Lane | 2024-04-01 18:09:37 | Re: Statistics Import and Export |