| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Xing Guo <higuoxing(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [plpython] Add missing volatile qualifier. |
| Date: | 2024-04-01 18:39:05 |
| Message-ID: | 1145662.1711996745@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> On Mon, Apr 01, 2024 at 11:57:07AM -0400, Tom Lane wrote:
>> Good catch! It looks like the consequences of a failure would be
>> pretty minimal --- AFAICS, no worse than a possible failure to remove
>> a refcount on Py_None --- but that's still a bug.
> Huh. I seem to have dropped that "volatile" shortly before committing for
> some reason [0].
Oh, I'd forgotten that discussion. Given that we were both confused
about the need for it, all the more reason to try to avoid using a
within-PG_TRY assignment.
> Your fix seems fine to me.
Thanks for looking, I'll push it shortly.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2024-04-01 18:46:15 | Re: Statistics Import and Export |
| Previous Message | Nathan Bossart | 2024-04-01 18:29:20 | Re: [plpython] Add missing volatile qualifier. |