| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Autogenerate some wait events code and documentation |
| Date: | 2023-08-29 12:21:48 |
| Message-ID: | 20230829122148.5o37bs7dszv2xybw@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-Aug-29, Michael Paquier wrote:
> On Tue, Aug 29, 2023 at 08:17:10AM +0200, Drouvot, Bertrand wrote:
> > Agree that done that way one could easily grep the events from the
> > source code and match them with wait_event_names.txt. Then I don't
> > think the "search" issue in the code is still a concern with the
> > current proposal.
>
> It could still be able to append WAIT_EVENT_ to the first column of
> the file. I'd just rather keep it shorter.
Yeah, I have a mild preference for keeping the prefix, but it's mild
because I also imagine that if somebody doesn't see the full symbol name
when grepping they will think to remove the prefix. So only -0.1.
I think the DOCONLY stuff should be better documented; they make no
sense without looking at the commit message for fa88928470b5.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-08-29 12:35:08 | Re: subscription/015_stream sometimes breaks |
| Previous Message | Nazir Bilal Yavuz | 2023-08-29 12:18:29 | Use the same Windows image on both VS and MinGW tasks |