| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Autogenerate some wait events code and documentation |
| Date: | 2023-08-29 22:55:49 |
| Message-ID: | ZO53dcx4snKqEjYQ@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 29, 2023 at 02:21:48PM +0200, Alvaro Herrera wrote:
> Yeah, I have a mild preference for keeping the prefix, but it's mild
> because I also imagine that if somebody doesn't see the full symbol name
> when grepping they will think to remove the prefix. So only -0.1.
So, are you fine with the patch as presented? Or are there other
things you'd like to see changed in the format?
> I think the DOCONLY stuff should be better documented; they make no
> sense without looking at the commit message for fa88928470b5.
Good point. However, with 0002 in place these are gone.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-08-29 22:56:33 | Re: Wrong usage of pqMsg_Close message code? |
| Previous Message | Peter Geoghegan | 2023-08-29 22:55:23 | Re: Is pg_regress --use-existing used by anyone or is it broken? |