| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: subscription/015_stream sometimes breaks |
| Date: | 2023-08-29 12:35:08 |
| Message-ID: | 20230829123508.u75gkmbhtnt45qwj@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-Aug-29, Amit Kapila wrote:
> On Mon, Aug 28, 2023 at 5:35 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > On Fri, Aug 25, 2023 at 8:15 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > IMO there are inconsistencies in the second patch that was pushed.
> I find your suggestions reasonable. Alvaro, do you have any comments?
Well, my main comment is that at this point I'm not sure these
isFooWorker() macros are worth their salt. It looks like we could
replace their uses with direct type comparisons in their callsites and
remove them, with no loss of readability. The am_sth_worker() are
probably a bit more useful, though some of the callsites could end up
better if replaced with straight type comparison.
All in all, I don't disagree with Peter's suggestions, but this is
pretty much in "meh" territory for me.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2023-08-29 12:39:42 | Re: Standardize spelling of "power of two" |
| Previous Message | Alvaro Herrera | 2023-08-29 12:21:48 | Re: Autogenerate some wait events code and documentation |