| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Dag Lem <dag(at)nimrod(dot)no>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Paul Ramsey <pramsey(at)cleverelephant(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: daitch_mokotoff module |
| Date: | 2023-04-08 01:25:32 |
| Message-ID: | 20230408012532.vrvssdi66rprd3aj@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2023-04-07 21:13:43 -0400, Tom Lane wrote:
> I wrote:
> > That seems fine to me. I'll check this over and see if I can get
> > it pushed today.
>
> I pushed this after some mostly-cosmetic fiddling. Most of the
> buildfarm seems okay with it, but crake's perlcritic run is not:
>
> ./contrib/fuzzystrmatch/daitch_mokotoff_header.pl: I/O layer ":utf8" used at line 15, column 5. Use ":encoding(UTF-8)" to get strict validation. ([InputOutput::RequireEncodingWithUTF8Layer] Severity: 5)
>
> Any suggestions on exactly how to pacify that?
You could follow it's advise and replace the :utf8 with :encoding(UTF-8), that
works here. Or disable it in that piece of code with ## no critic
(RequireEncodingWithUTF8Layer) Or we could disable the warning in
perlcriticrc for all files?
Unless it's not available with old versions, using :encoding(UTF-8) seems
sensible?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-04-08 01:27:47 | Re: daitch_mokotoff module |
| Previous Message | Thomas Munro | 2023-04-08 01:18:55 | check_GUC_init(wal_writer_flush_after) fails with non-default block size |