| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Dag Lem <dag(at)nimrod(dot)no>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Paul Ramsey <pramsey(at)cleverelephant(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: daitch_mokotoff module |
| Date: | 2023-04-08 01:27:47 |
| Message-ID: | 3274276.1680917267@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2023-04-07 21:13:43 -0400, Tom Lane wrote:
>> I pushed this after some mostly-cosmetic fiddling. Most of the
>> buildfarm seems okay with it, but crake's perlcritic run is not:
>>
>> ./contrib/fuzzystrmatch/daitch_mokotoff_header.pl: I/O layer ":utf8" used at line 15, column 5. Use ":encoding(UTF-8)" to get strict validation. ([InputOutput::RequireEncodingWithUTF8Layer] Severity: 5)
> Unless it's not available with old versions, using :encoding(UTF-8) seems
> sensible?
Yeah, that's the obvious fix, I was just wondering if people with
more perl-fu than I have see a problem with it. But I'll go ahead
and push that for now.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2023-04-08 01:28:08 | Re: Kerberos delegation support in libpq and postgres_fdw |
| Previous Message | Andres Freund | 2023-04-08 01:25:32 | Re: daitch_mokotoff module |