| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Dag Lem <dag(at)nimrod(dot)no> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Paul Ramsey <pramsey(at)cleverelephant(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: daitch_mokotoff module |
| Date: | 2023-04-08 01:13:43 |
| Message-ID: | 3271512.1680916423@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> That seems fine to me. I'll check this over and see if I can get
> it pushed today.
I pushed this after some mostly-cosmetic fiddling. Most of the
buildfarm seems okay with it, but crake's perlcritic run is not:
./contrib/fuzzystrmatch/daitch_mokotoff_header.pl: I/O layer ":utf8" used at line 15, column 5. Use ":encoding(UTF-8)" to get strict validation. ([InputOutput::RequireEncodingWithUTF8Layer] Severity: 5)
Any suggestions on exactly how to pacify that?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-04-08 01:18:55 | check_GUC_init(wal_writer_flush_after) fails with non-default block size |
| Previous Message | Tom Lane | 2023-04-08 01:04:22 | Re: Making background psql nicer to use in tap tests |