| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, samay sharma <smilingsamay(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [RFC] building postgres with meson - v13 |
| Date: | 2022-09-26 06:46:54 |
| Message-ID: | 20220926064654.klmyhdas33bzil3y@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-09-26 06:24:42 +0000, wangw(dot)fnst(at)fujitsu(dot)com wrote:
> I tried to use meson and ninja and they are really efficient.
> But when I tried to specify "c_args", it did not take effect.
They should take effect, but won't be shown in the summary section
currently. That currently only shows the flags chosen by the configure step,
rather than user specified ones.
> After I made the below modifications, the specified "c_args" took effect.
> ```
> @@ -2439,6 +2439,10 @@ endif
>
> # Set up compiler / linker arguments to be used everywhere, individual targets
> # can add further args directly, or indirectly via dependencies
> +
> +tmp_c_args = get_option('c_args')
> +cflags += tmp_c_args
> +
> add_project_arguments(cflags, language: ['c'])
> add_project_arguments(cppflags, language: ['c'])
> add_project_arguments(cflags_warn, language: ['c'])
> ```
That'll likely end up with the same cflags added multiple times. You should
see them when building with ninja -v.
How about adding c_args to the summary, in a separate line? I think that'd
clarify what's happening?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | kuroda.hayato@fujitsu.com | 2022-09-26 06:57:28 | [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t" |
| Previous Message | Wolfgang Walther | 2022-09-26 06:33:28 | Re: Add ON CONFLICT DO RETURN clause |