RE: [RFC] building postgres with meson - v13

On Mon, Sep 26, 2022 at 14:47 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> On 2022-09-26 06:24:42 +0000, wangw(dot)fnst(at)fujitsu(dot)com wrote:
> > I tried to use meson and ninja and they are really efficient.
> > But when I tried to specify "c_args", it did not take effect.
>
> They should take effect, but won't be shown in the summary section
> currently. That currently only shows the flags chosen by the configure step,
> rather than user specified ones.
>
>
> > After I made the below modifications, the specified "c_args" took effect.
> > ```
> > @@ -2439,6 +2439,10 @@ endif
> >
> > # Set up compiler / linker arguments to be used everywhere, individual
> targets
> > # can add further args directly, or indirectly via dependencies
> > +
> > +tmp_c_args = get_option('c_args')
> > +cflags += tmp_c_args
> > +
> > add_project_arguments(cflags, language: ['c'])
> > add_project_arguments(cppflags, language: ['c'])
> > add_project_arguments(cflags_warn, language: ['c'])
> > ```
>
> That'll likely end up with the same cflags added multiple times. You should
> see them when building with ninja -v.

Thanks for sharing the information.
I saw the user specified CFLAG when building with `ninja -v`.

But, after installing PG with command `ninja -v install`, pg_config does not
show the user specified CFLAG. Should we print this information there?

> How about adding c_args to the summary, in a separate line? I think that'd
> clarify what's happening?

Yes, I think it might be better.

Regards,
Wang wei