From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: makefiles writing to $@ should first write to $@.new |
Date: | 2022-01-24 04:07:50 |
Message-ID: | 20220124040750.iizc42vlhjpyblnn@jrouhaud |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On Mon, Jan 24, 2022 at 12:41:49PM +0900, Michael Paquier wrote:
> On Sun, Jan 23, 2022 at 09:23:05PM -0600, Justin Pryzby wrote:
> > If the rule is interrupted (due to ^C or ENOSPC), foo can be 0 bytes or
> > partially written, but won't be rebuilt until someone runs distclean or debugs
> > it and removes the individual file, as I did for errcodes.h.
>
> Honestly, I am not sure that this worth bothering about. This comes
> down to a balance between the code complexity and the likelihood of a
> failure, and the odds are not in favor of the later IMO. Now, it
> could be perhaps possible to make such a change simple enough while it
> avoids a lot of technical debt, but we have a lot of custom rules
> particularly in src/bin/, so changing all that or even require that in
> future changes is not really appealing.
I agree, it doesn't seem worth it.
From | Date | Subject | |
---|---|---|---|
Next Message | David G. Johnston | 2022-01-24 04:20:37 | Re: Bogus duplicate command issued in pg_dump |
Previous Message | Michael Paquier | 2022-01-24 03:58:34 | Re: [BUG]Update Toast data failure in logical replication |