| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: makefiles writing to $@ should first write to $@.new |
| Date: | 2022-01-24 03:41:49 |
| Message-ID: | Ye4f/cVWGf8xI8yP@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 23, 2022 at 09:23:05PM -0600, Justin Pryzby wrote:
> If the rule is interrupted (due to ^C or ENOSPC), foo can be 0 bytes or
> partially written, but won't be rebuilt until someone runs distclean or debugs
> it and removes the individual file, as I did for errcodes.h.
Honestly, I am not sure that this worth bothering about. This comes
down to a balance between the code complexity and the likelihood of a
failure, and the odds are not in favor of the later IMO. Now, it
could be perhaps possible to make such a change simple enough while it
avoids a lot of technical debt, but we have a lot of custom rules
particularly in src/bin/, so changing all that or even require that in
future changes is not really appealing.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-01-24 03:47:09 | Re: row filtering for logical replication |
| Previous Message | Amit Kapila | 2022-01-24 03:34:58 | Re: Skipping logical replication transactions on subscriber side |