From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: makefiles writing to $@ should first write to $@.new |
Date: | 2022-01-24 14:32:17 |
Message-ID: | 1873415.1643034737@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Julien Rouhaud <rjuju123(at)gmail(dot)com> writes:
> On Mon, Jan 24, 2022 at 12:41:49PM +0900, Michael Paquier wrote:
>> Honestly, I am not sure that this worth bothering about. This comes
>> down to a balance between the code complexity and the likelihood of a
>> failure, and the odds are not in favor of the later IMO. Now, it
>> could be perhaps possible to make such a change simple enough while it
>> avoids a lot of technical debt, but we have a lot of custom rules
>> particularly in src/bin/, so changing all that or even require that in
>> future changes is not really appealing.
> I agree, it doesn't seem worth it.
Agreed. Another reason to not bother about this is the likelihood
that it'd all be wasted effort as soon as we switch to meson.
If that project fails, I'd be open to revisiting this issue;
but I don't think we should spend time improving the Makefiles
right now.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | David G. Johnston | 2022-01-24 14:42:34 | Re: Skipping logical replication transactions on subscriber side |
Previous Message | Dipesh Pandit | 2022-01-24 14:29:55 | Re: refactoring basebackup.c |