| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Removed unused import modules from tap tests |
| Date: | 2021-11-10 12:37:23 |
| Message-ID: | 202111101237.xzlr2edsns5e@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Nov-10, Michael Paquier wrote:
> I would not have bothered changing things if the names of the modules
> were the same across stable branches to minimize merge conflicts.
>
> However, everything has changed on HEAD, so there is a good argument
> for simplifying the tests as you are proposing here. Any thoughts
> from others?
I agree with your reasoning, but I wonder what's the *benefit* of
removing those includes. IOW, what's the reason not to simply drop the
patch?
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-11-10 12:42:06 | Re: Commitfest 2021-11 Patch Triage - Part 2 |
| Previous Message | Alvaro Herrera | 2021-11-10 12:14:30 | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |