Re: Removed unused import modules from tap tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Removed unused import modules from tap tests
Date: 2021-11-10 03:34:53
Message-ID: YYs93TL2ucEQmnpS@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 09, 2021 at 09:48:30PM +0530, vignesh C wrote:
> While trying to add some new tests, I found that
> PostgreSQL::Test::Utils is not required. I felt
> PostgreSQL::Test::Utils can be removed from a lot of tap tests which
> do not require it. I removed it, ran the tests and found the tests to
> be executing fine. I have made a patch including the changes for it.
> If this import can be removed, kindly accept the attached patch for
> the same.

I would not have bothered changing things if the names of the modules
were the same across stable branches to minimize merge conflicts.

However, everything has changed on HEAD, so there is a good argument
for simplifying the tests as you are proposing here. Any thoughts
from others?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2021-11-10 03:39:11 Re: 2021-11-11 release announcement draft
Previous Message Amit Kapila 2021-11-10 03:17:26 Re: Logical insert/update/delete WAL records for custom table AMs