Re: Commitfest 2021-11 Patch Triage - Part 2

On Tue, Nov 09, 2021 at 03:12:39PM +0100, Daniel Gustafsson wrote:
> 2800: CLUSTER on partitioned table
> ==================================
> The the patch above, it too spawned off from the REINDEX CONCURRENTLY thread
> but seems to have stalled awaiting more review. There was scepticism raised
> over the usefulness vs code weight tradeoff, but the response to this haven't
> really been followed up on. Alvaro and Michael, do you have any changed
> thoughts on Justins patch reorg or do you stil feel this isn't worth going
> ahead with?

My feeling on this one is that the addition was not worth the
complexity, and I got the impression that the handling of
pg_index.indisclustered was rather blurry when it came to multiple
layers of partitions.

> 2861: pg_upgrade test for binary compatibility of core data types
> =================================================================
> This patch is also actively worked on and reviewed, and bits from this thread
> have already landed. Do you think this can land in its entirety in this CF
> Michael?

The remaining parts are the addition of a SQL test, which requires
more comments and documentation as the thing is complex to follow, and
the switch of the upgrade SQL queries to a file. I need to do a pass
over it, but that seems worth having on its own. For the second
point, I wanted to double-check first with Andrew about how much code
we could cut in the buildfarm client code.

Thanks for the summary!
--
Michael