| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Christoph Berg <myon(at)debian(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: compute_query_id and pg_stat_statements |
| Date: | 2021-05-15 23:01:25 |
| Message-ID: | 20210515230125.GA2951@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-May-15, Bruce Momjian wrote:
> On Sat, May 15, 2021 at 02:21:59PM -0400, Álvaro Herrera wrote:
> > I wonder why the initial line says "query hash" instead of "query
> > identifier". Do we want to say "hash" everywhere? Why didn't we name
> > the GUC "compute_query_hash" in that case?
>
> It is queryid (no underscore) in pg_stat_statements, which was a whole
> different discussion. ;-)
Yeah, I realize that, but I wonder if we shouldn't use the term "query
identifier" instead of "query hash" in that paragraph.
> I also added Alvaro as an author of the compute_query_id item.
I've been wondering if I should ask to stick my name in other features I
helped get committed -- specifically the PQtrace() item and autovacuum
for partitioned tables. I'll go comment in the release notes thread.
--
Álvaro Herrera Valdivia, Chile
"Digital and video cameras have this adjustment and film cameras don't for the
same reason dogs and cats lick themselves: because they can." (Ken Rockwell)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-05-15 23:05:35 | Re: PG 14 release notes, first draft |
| Previous Message | Tom Lane | 2021-05-15 22:21:13 | Re: prion failed with ERROR: missing chunk number 0 for toast value 14334 in pg_toast_2619 |