| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Christoph Berg <myon(at)debian(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: compute_query_id and pg_stat_statements |
| Date: | 2021-05-17 03:12:34 |
| Message-ID: | 20210517031234.GD24531@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 15, 2021 at 07:01:25PM -0400, Álvaro Herrera wrote:
> On 2021-May-15, Bruce Momjian wrote:
>
> > On Sat, May 15, 2021 at 02:21:59PM -0400, Álvaro Herrera wrote:
>
> > > I wonder why the initial line says "query hash" instead of "query
> > > identifier". Do we want to say "hash" everywhere? Why didn't we name
> > > the GUC "compute_query_hash" in that case?
> >
> > It is queryid (no underscore) in pg_stat_statements, which was a whole
> > different discussion. ;-)
>
> Yeah, I realize that, but I wonder if we shouldn't use the term "query
> identifier" instead of "query hash" in that paragraph.
Yes, of course, you are right --- updated text:
<listitem>
<!--
Author: Bruce Momjian <bruce(at)momjian(dot)us>
2021-04-07 [4f0b0966c] Make use of in-core query id added by commit 5fd9dfa5f5
Author: Bruce Momjian <bruce(at)momjian(dot)us>
2021-04-07 [f57a2f5e0] Add csvlog output for the new query_id value
Author: Bruce Momjian <bruce(at)momjian(dot)us>
2021-04-20 [9660834dd] adjust query id feature to use pg_stat_activity.query_id
Author: Bruce Momjian <bruce(at)momjian(dot)us>
2021-05-03 [f7a97b6ec] Update query_id computation
Author: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
2021-05-15 [cafde58b3] Allow compute_query_id to be set to 'auto' and make it d
-->
<para>
If server variable compute_query_id is enabled, display the query
id in pg_stat_activity, EXPLAIN VERBOSE, csvlog, and optionally
in log_line_prefix (Julien Rouhaud)
</para>
<para>
A query id computed by an extension will also be displayed.
</para>
</listitem>
>
> > I also added Alvaro as an author of the compute_query_id item.
>
> I've been wondering if I should ask to stick my name in other features I
> helped get committed -- specifically the PQtrace() item and autovacuum
> for partitioned tables. I'll go comment in the release notes thread.
Yes, done.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2021-05-17 03:12:51 | Re: compute_query_id and pg_stat_statements |
| Previous Message | Bruce Momjian | 2021-05-17 03:10:50 | Re: PG 14 release notes, first draft |