From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Christoph Berg <myon(at)debian(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: compute_query_id and pg_stat_statements |
Date: | 2021-05-15 21:32:58 |
Message-ID: | 20210515213258.GA21748@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, May 15, 2021 at 02:21:59PM -0400, Álvaro Herrera wrote:
> I commented out the release notes para that is now wrong. What remains
> is this:
>
> Move query hash computation from pg_stat_statements to the core server (Julien Rouhaud)
>
> We could perhaps add something like
>
> Extension pg_stat_statements continues to work without requiring any
> configuration changes.
>
> but that seems a bit pointless. Or maybe
>
> Extension pg_stat_statements automatically enables query identifier
> computation if compute_query_id is set to auto. Third-party modules
> to compute query identifiers can be installed and used if this is set
> to off.
>
OK, new text is:
<listitem>
<!--
Author: Bruce Momjian <bruce(at)momjian(dot)us>
2021-04-07 [5fd9dfa5f] Move pg_stat_statements query jumbling to core.
-->
<para>
Move query hash computation from pg_stat_statements to the core
server (Julien Rouhaud)
</para>
<para>
The new server variable compute_query_id's default of 'auto' will
automatically enable query id computation when this extension
is loaded.
</para>
</listitem>
I also added Alvaro as an author of the compute_query_id item.
> I wonder why the initial line says "query hash" instead of "query
> identifier". Do we want to say "hash" everywhere? Why didn't we name
> the GUC "compute_query_hash" in that case?
It is queryid (no underscore) in pg_stat_statements, which was a whole
different discussion. ;-)
> Anyway, let me remind you that it is pretty common to require initdb
> during the beta period.
True.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-05-15 22:21:13 | Re: prion failed with ERROR: missing chunk number 0 for toast value 14334 in pg_toast_2619 |
Previous Message | Bruce Momjian | 2021-05-15 18:30:15 | Re: PG 14 release notes, first draft |