Re: TRUNCATE on foreign table

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Kohei KaiGai <kaigai(at)heterodb(dot)com>, Kazutaka Onishi <onishi(at)heterodb(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Subject: Re: TRUNCATE on foreign table
Date: 2021-04-13 03:46:37
Message-ID: 20210413034637.GA6091@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 13, 2021 at 12:38:35PM +0900, Fujii Masao wrote:
> + <structname>Relation</structname> data structures for each
> + foreign tables to be truncated.
>
> "foreign tables" should be "foreign table" because it follows "each"?

Yes, you're right.

> + <para>
> + <literal>behavior</literal> is either
> + <literal>DROP_RESTRICT</literal> or <literal>DROP_CASCADE</literal>.
> + <literal>DROP_CASCADE</literal> indicates that the
> + <literal>CASCADE</literal> option was specified in the original
> <command>TRUNCATE</command> command.
>
> Why did you remove the description for DROP_RESTRICT?

Because in order to handle the default/unspecified case, the description was
going to need to be something like:

| DROP_RESTRICT indicates that the RESTRICT option was specified in the original
| truncate command (or CASCADE option was NOT specified).

--
Justin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2021-04-13 04:23:23 PG Docs - logical decoding output plugins - fix typo
Previous Message Fujii Masao 2021-04-13 03:38:35 Re: TRUNCATE on foreign table