Re: TRUNCATE on foreign table

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Kohei KaiGai <kaigai(at)heterodb(dot)com>, Kazutaka Onishi <onishi(at)heterodb(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Subject: Re: TRUNCATE on foreign table
Date: 2021-04-13 03:38:35
Message-ID: bf469e1b-d500-9f0d-36fc-e9515594f3bf@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021/04/13 10:21, Bharath Rupireddy wrote:
> I agree to convert to bits and pass it as int value which is
> extensible i.e. we can pass more extra parameters across if required.

Looks good to me.

> Also I'm not in favour of removing relids_extra altogether, we might
> need this to send some info in future.
>
> Both 0001 and 0002(along with the new phrasings) look good to me.

Thanks for updating the patches!

One question is; "CONTEXT" of "TRUNCATE_REL_CONTEXT_ONLY" is required?
If not, I'm tempted to shorten the name to "TRUNCATE_REL_ONLY" or something.

+ <structname>Relation</structname> data structures for each
+ foreign tables to be truncated.

"foreign tables" should be "foreign table" because it follows "each"?

+ <para>
+ <literal>behavior</literal> is either
+ <literal>DROP_RESTRICT</literal> or <literal>DROP_CASCADE</literal>.
+ <literal>DROP_CASCADE</literal> indicates that the
+ <literal>CASCADE</literal> option was specified in the original
<command>TRUNCATE</command> command.

Why did you remove the description for DROP_RESTRICT?

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-04-13 03:46:37 Re: TRUNCATE on foreign table
Previous Message Andres Freund 2021-04-13 03:06:51 Re: [PATCH] Identify LWLocks in tracepoints