Re: TRUNCATE on foreign table

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Kohei KaiGai <kaigai(at)heterodb(dot)com>, Kazutaka Onishi <onishi(at)heterodb(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Subject: Re: TRUNCATE on foreign table
Date: 2021-04-13 06:44:40
Message-ID: e201283b-f246-1489-40d3-418ab0729fb2@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021/04/13 12:46, Justin Pryzby wrote:
> On Tue, Apr 13, 2021 at 12:38:35PM +0900, Fujii Masao wrote:
>> + <structname>Relation</structname> data structures for each
>> + foreign tables to be truncated.
>>
>> "foreign tables" should be "foreign table" because it follows "each"?
>
> Yes, you're right.
>
>> + <para>
>> + <literal>behavior</literal> is either
>> + <literal>DROP_RESTRICT</literal> or <literal>DROP_CASCADE</literal>.
>> + <literal>DROP_CASCADE</literal> indicates that the
>> + <literal>CASCADE</literal> option was specified in the original
>> <command>TRUNCATE</command> command.
>>
>> Why did you remove the description for DROP_RESTRICT?
>
> Because in order to handle the default/unspecified case, the description was
> going to need to be something like:
>
> | DROP_RESTRICT indicates that the RESTRICT option was specified in the original
> | truncate command (or CASCADE option was NOT specified).

What about using "requested" instead of "specified"? If neither RESTRICT nor
CASCADE is specified, we can think that user requested the default behavior,
i.e., RESTRICT. So, for example,

<literal>behavior</literal> is either <literal>DROP_RESTRICT</literal> or
<literal>DROP_CASCADE</literal>, which indicates that the
<literal>RESTRICT</literal> or <literal>CASCADE</literal> option was
requested in the original <command>TRUNCATE</command> command, respectively.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2021-04-13 07:02:20 Re: Retry in pgbench
Previous Message Ian Zagorskikh 2021-04-13 06:35:51 Re: Contribution to PostgreSQL - please give an advice