| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Some remaining htonl() and ntohl() calls in the code |
| Date: | 2020-10-14 20:41:23 |
| Message-ID: | 20201014204123.vcewobvt3bp4jr7h@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2020-10-14 14:53:03 +0900, Michael Paquier wrote:
> Since 510b8cbf, we have in-core equivalents for htonl(), ntohl() & co
> through pg_bswap.h that allows to compile with a built-in function if
> the compiler used has one.
>
> All the existing calls in the code tree have been changed with
> 0ba99c84 for performance reasons (except the libpq examples), however
> the FE/BE code of GSSAPI encryption code did not get this call in
> b0b39f7. I think that we had better switch to the built-ins functions
> as well for this case. The argument of consistency matters here, but
> also perhaps the argument of performance, where it may not be easy to
> measure a difference.
+1
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2020-10-14 20:46:13 | Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump. |
| Previous Message | Andres Freund | 2020-10-14 20:31:03 | Re: More aggressive vacuuming of temporary tables |