Some remaining htonl() and ntohl() calls in the code

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Some remaining htonl() and ntohl() calls in the code
Date: 2020-10-14 05:53:03
Message-ID: 20201014055303.GG3349@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

Since 510b8cbf, we have in-core equivalents for htonl(), ntohl() & co
through pg_bswap.h that allows to compile with a built-in function if
the compiler used has one.

All the existing calls in the code tree have been changed with
0ba99c84 for performance reasons (except the libpq examples), however
the FE/BE code of GSSAPI encryption code did not get this call in
b0b39f7. I think that we had better switch to the built-ins functions
as well for this case. The argument of consistency matters here, but
also perhaps the argument of performance, where it may not be easy to
measure a difference.

Attached is a patch to do the switch. None of the files changed
include arpa/inet.h. Any thoughts?

Thanks,
--
Michael

Attachment Content-Type Size
htonl-fix-v1.patch text/x-diff 2.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2020-10-14 06:27:48 Re: Wired if-statement in gen_partprune_steps_internal
Previous Message Takashi Menjo 2020-10-14 05:30:57 RE: [PoC] Non-volatile WAL buffer