| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, movead(dot)li(at)highgo(dot)ca, pgsql-hackers(at)postgresql(dot)org, ahsan(dot)hadi(at)highgo(dot)ca |
| Subject: | Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump. |
| Date: | 2020-10-14 20:46:13 |
| Message-ID: | 20201014204613.lxts3w6lc4lsv7zh@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2020-10-14 15:52:43 +0900, Michael Paquier wrote:
> Yeah. In its current shape, it means that only pg_waldump would be
> able to know this information. If you make this information part of
> xlogdesc.c, any consumer of the WAL record descriptions would be able
> to show this information, so it would provide a consistent output for
> any kind of tools.
I'm not convinced by this argument. The only case where accounting for
the "wasted" length seems really interesting is for --stats=record - and
for that including it in the record description is useless. When looking
at plain records the length is sufficiently deducable by looking at the
next record's LSN.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2020-10-14 20:46:59 | Re: Minor documentation error regarding streaming replication protocol |
| Previous Message | Andres Freund | 2020-10-14 20:41:23 | Re: Some remaining htonl() and ntohl() calls in the code |