Re: pgsql: Remove testing for precise LSN/reserved bytes in new TAP test

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove testing for precise LSN/reserved bytes in new TAP test
Date: 2020-04-10 15:23:45
Message-ID: 20200410152345.GA13282@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2020-Apr-10, Kyotaro Horiguchi wrote:

> > Yeah. We have at least four different buildfarm members complaining
> > about this test case. I took this patch and further lobotomized the
> > tests by removing *all* dependencies on restart_lsn and
> > pg_current_wal_lsn(). If anybody wants to put any of that back,
> > the burden of proof will be on them to show why we should believe
> > the results will be stable, not for the buildfarm to demonstrate
> > that they're not.
>
> I think the significant part of the test is wal_status. So I'm not
> eager to get it back.

Agreed. Thanks for stabilizing it.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-04-10 15:30:34 Re: pgsql: doc: add examples of creative use of unique expression indexes
Previous Message Tom Lane 2020-04-10 14:44:39 pgsql: Doc: sync CREATE GROUP syntax synopsis with CREATE ROLE.