Re: pgsql: Remove testing for precise LSN/reserved bytes in new TAP test

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: alvherre(at)alvh(dot)no-ip(dot)org, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove testing for precise LSN/reserved bytes in new TAP test
Date: 2020-04-10 02:33:32
Message-ID: 20200410.113332.337305854143176317.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

At Thu, 09 Apr 2020 17:31:59 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote in
> Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> writes:
> >> Sorry for the wrong test file.
> >> Checking in lower precision would be sufficient.
>
> > I noticed that prailiedog failed in another mode.
>
> Yeah. We have at least four different buildfarm members complaining
> about this test case. I took this patch and further lobotomized the
> tests by removing *all* dependencies on restart_lsn and
> pg_current_wal_lsn(). If anybody wants to put any of that back,
> the burden of proof will be on them to show why we should believe
> the results will be stable, not for the buildfarm to demonstrate
> that they're not.

I think the significant part of the test is wal_status. So I'm not
eager to get it back.

Thanks!

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-04-10 14:44:39 pgsql: Doc: sync CREATE GROUP syntax synopsis with CREATE ROLE.
Previous Message Michael Paquier 2020-04-10 02:26:45 pgsql: Fix collection of typos and grammar mistakes in the tree