Re: pgsql: Remove testing for precise LSN/reserved bytes in new TAP test

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: alvherre(at)alvh(dot)no-ip(dot)org, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove testing for precise LSN/reserved bytes in new TAP test
Date: 2020-04-09 21:31:59
Message-ID: 12174.1586467919@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> writes:
>> Sorry for the wrong test file.
>> Checking in lower precision would be sufficient.

> I noticed that prailiedog failed in another mode.

Yeah. We have at least four different buildfarm members complaining
about this test case. I took this patch and further lobotomized the
tests by removing *all* dependencies on restart_lsn and
pg_current_wal_lsn(). If anybody wants to put any of that back,
the burden of proof will be on them to show why we should believe
the results will be stable, not for the buildfarm to demonstrate
that they're not.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2020-04-09 21:49:47 Re: pgsql: Rationalize GetWalRcv{Write,Flush}RecPtr().
Previous Message Tom Lane 2020-04-09 21:29:04 pgsql: Further stabilize results of 019_replslot_limit.pl.