From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | alvherre(at)alvh(dot)no-ip(dot)org |
Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Remove testing for precise LSN/reserved bytes in new TAP test |
Date: | 2020-04-09 01:13:39 |
Message-ID: | 20200409.101339.1252894237035894186.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
At Wed, 08 Apr 2020 14:44:52 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> At Wed, 08 Apr 2020 03:33:04 +0000, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote in
> > Remove testing for precise LSN/reserved bytes in new TAP test
> >
> > Trying to ensure that a slot's restart_lsn or amount of reserved bytes
> > exactly match some specific values seems unnecessary, and fragile as
> > shown by failures in multiple buildfarm members.
>
> Sorry for the wrong test file.
> Checking in lower precision would be sufficient.
I noticed that prailiedog failed in another mode.
not ok 5 - check that max_slot_wal_keep_size is working
# Failed test 'check that max_slot_wal_keep_size is working'
# at t/019_replslot_limit.pl line 89.
# got: '0/D00198|normal|5120 kB'
# expected: '0/D00164|normal|5120 kB'
The first colomn in the result is restart_lsn and it's not essential
to the test. It is removed in the attached test script. Precise LSN is
not reffered in tht test script.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2020-04-09 03:57:19 | pgsql: Add note in pg_stat_statements documentation about planning stat |
Previous Message | Andrew Dunstan | 2020-04-08 21:56:01 | pgsql: Msys2 tweaks for pg_validatebackup corruption test |